Auth: migrate hash string to be directly compatible with pg/pgbouncer #33714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
reviewed
Sep 25, 2025
There was a problem hiding this comment.
Thanks for adding tests!
Nightly triggered: https://buildkite.com/materialize/nightly/builds/13582
DAlperin
force-pushed
the
dov/migrate-auth-string-compatability
branch
from
6c8ceef to
3baac42
Compare
|
oops had to rebase https://buildkite.com/materialize/nightly/builds/13593 |
DAlperin
force-pushed
the
dov/migrate-auth-string-compatability
branch
5 times, most recently
from
e82e4e9 to
6286755
Compare
This adds auth testdrive tests (and the ability for testdrive to test auth).
DAlperin
force-pushed
the
dov/migrate-auth-string-compatability
branch
3 times, most recently
from
f1f3b1c to
e25a29c
Compare
DAlperin
force-pushed
the
dov/migrate-auth-string-compatability
branch
from
e25a29c to
643670c
Compare
When I originally wrote auth I used a postgres inspired string format to store the hashes, but didn't index on making it 1:1 compatible since we had originally decided not to surface the hash to the user... That didn't last. Notion (and perhaps others) want to be able to use pgbouncer. It would be easy enough to give instructions/a script to make the existing hash format into the one pgbouncer wants in its config file but... we could just not do that.
DAlperin
force-pushed
the
dov/migrate-auth-string-compatability
branch
from
643670c to
a119277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally wrote auth I used a postgres inspired string format to
store the hashes, but didn't index on making it 1:1 compatible since we
had originally decided not to surface the hash to the user... That
didn't last.
Notion (and perhaps others) want to be able to use pgbouncer. It would
be easy enough to give instructions/a script to make the existing hash
format into the one pgbouncer wants in its config file but... we could
just not do that.
(This PR also adds platform-checks for passwords to ensure functionality
across versions)
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.