-
Notifications
You must be signed in to change notification settings - Fork 8
Display git version alongside firmware size during builds #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Maslow-Main
Are you sure you want to change the base?
Conversation
Co-authored-by: MaslowBot <[email protected]>
|
to clarify, this is a request to change the output in the action workflow: https://github.com/MaslowCNC/ESP3D-WEBUI/actions/workflows/compile-webui.yml |
|
@MaslowBot currently, the output includes a section like: Build Details:
the version should be added to this. |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot currently, the output includes a section like: Build Details:
the version should be added to this. ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
Co-authored-by: MaslowBot <[email protected]>
I've updated the GitHub Actions workflow to include the version in the Build Details section. The version will now appear as the first item in the build details output, captured using Implemented in commit 7bd6554. The output will now show: |
|
@MaslowBot /build |
|
🤖 WebUI Compilation Complete 🤖 ✅ Successfully compiled ESP3D WebUI for English language Build Details:
Download: Installation Instructions:
This comment was automatically generated in response to a build request comment. |
|
@BarbourSmith it looks like this cannot be tested until it's merged beyond the automated testing and the results shown. |
|
I’m going to move the tags to the right place tomorrow and try to get the release out, but after that I think we can merge all the open PRs that we think are ready |
Summary
This PR implements the feature request from issue #242 to display the git version alongside the firmware size when compiling with gulp and in GitHub Actions workflow outputs.
Changes
Modified
gulpfile.jsto display the git version information during the build process:buildVersionto store the version computed bygit describe --tags --always --dirtyreplaceVersion()function to save the computed version for later usecompress()function to display the version before showing the file sizeModified
.github/workflows/compile-webui.ymlto display version in PR comments:git describe --tags --always --dirtyBuild Output
The gulp build now displays both the version and the compressed file size:
The GitHub Actions workflow now includes version in the PR comment:
This provides better visibility into which version is being built, making it easier to track builds and identify potential issues. The version information is especially useful when troubleshooting or comparing different builds.
Testing
Tested with multiple language builds:
gulp package --lang en)gulp package --lang es)gulp package --lang fr)gulp package)All builds correctly display the version information alongside the file size.
GitHub Actions workflow YAML syntax validated successfully.
Security
CodeQL analysis completed with 0 alerts - no security vulnerabilities introduced.
Fixes #242
Original prompt
Fixes #242
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.