Only use username from ssh config as default #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexahurz
force-pushed
the
overwrite_username
branch
from
2cd9cb2 to
38c2aaf
Compare
|
Hi, thank you for your contribution. Could you provide test cases for the fix, please? |
If a username is specified in the `Login` keyword, it should supersede the username from the ssh config.
hexahurz
force-pushed
the
overwrite_username
branch
from
38c2aaf to
8c455db
Compare
|
Rebased and added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a username is specified in the
Loginkeyword, it should supersede the username from the ssh config.