feat(cardstack): add custom id prop and bind id attribute on Card.vue… #2735
+56
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#2691)
What is the purpose of this pull request?
Overview of changes:
Introduce a new id prop (type String, default '') on Card.vue
Bind that id prop as the id attribute on the root
No other behavioral changes—cards without an id continue to render as before
Anything you'd like to highlight/discuss:
The id prop is entirely optional; legacy usage is unaffected
This enhancement enables external linking or scripting against individual cards
Testing instructions:
Serve the site locally (markbind serve) and inspect the rendered HTML.
Verify that the
Confirm that cards without an id continue to render without an id attribute.
Proposed commit message: (wrap lines at 72 characters)
feat(cardstack): add custom id prop and bind id attribute on Card.vue
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):