Fix issue with 404 page not working locally #2724
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Partially fixes #2717
Adds an error handler to explicitly send the
404.html
upon error 404. It removes the previous check forerr.status === 404
and handles the error in a newly added middleware.Anything you'd like to highlight/discuss:
This PR only partially fixes #2717. It ensures that when serving the site locally, any invalid pages without a corresponding file will properly respond with the
404.html
file. It does not fix the current rendering issue with the default404.html
file causing it to be blank. That issue is related to #2716.Testing instructions:
markbind serve
http://127.0.0.1:8080/test
404.html
file is shown as the response (To avoid Centre-align feature is not working #2716, this requires adjusting404.html
such as removing the use of center-align)Proposed commit message: (wrap lines at 72 characters)
Fix issue with 404 page not working locally
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):