Skip to content

AnnotationDataFilter: support annotations with stringArray type values #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

AnnotationDataFilter: support annotations with stringArray type values #996

wants to merge 2 commits into from

Conversation

koctuk999
Copy link
Contributor

@koctuk999 koctuk999 requested a review from Malinskiy as a code owner April 15, 2025 09:00
@Malinskiy
Copy link
Member

@koctuk999 please add tests with string array value as well as some other type to check how this code behaves

@koctuk999
Copy link
Contributor Author

@koctuk999 please add tests with string array value as well as some other type to check how this code behaves

added tests

@Malinskiy
Copy link
Member

FYI this might break in the future, but since it's an undocumented filter I'm ok with that.
There is a use-case for all of the values to match the regex, not any. If this comes up - will need to rework this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malinskiy Malinskiy Awaiting requested review from Malinskiy Malinskiy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koctuk999 @Malinskiy @kvsolovev