Skip to content

Conversation

@simkim
Copy link

@simkim simkim commented Sep 22, 2022

No description provided.

@simkim simkim marked this pull request as draft September 22, 2022 13:34
Copy link

@pimpin pimpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetics suggestions on empty lines after early raise or return.

@simkim simkim changed the title Array, Nested, Array of Nested, Nested of Nested [Breaking changes] Array, Nested, Array of Nested, Nested of Nested Sep 22, 2022
Copy link

@fab-girard fab-girard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 2 sections for array and nested attributes with examples in readme please?

@simkim simkim marked this pull request as ready for review September 29, 2022 12:58
@simkim simkim marked this pull request as draft September 29, 2022 12:58
@simkim simkim marked this pull request as ready for review September 29, 2022 13:00
@simkim simkim requested review from fab-girard and pimpin and removed request for fab-girard and pimpin September 29, 2022 13:00
@avsej
Copy link

avsej commented Sep 29, 2022

when this PR will be merged, I will rebase my #55 and fix conflicts if there will be detected.

@giallon giallon merged commit a1fbeb2 into Mapotempo:master Oct 11, 2022
@DamienVoreiter DamienVoreiter deleted the nested_and_array branch January 16, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants