fix(config) Make Default and Deserialize more in sync #294
+112
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, when I'm thinking about it. Maybe it is worth rewriting all the types in the config module to have consistent default implementations to the serde derivations. Also, it would help with reducing the amount of small functions that just return a single value. If there is interest in this change. I'm willing to do it. The question then would be if it should be part of this PR or part of some refactoring PR. |
|
It's a good idea 👌 . We can do it in this PR or in different PRs. From my point of view, there's no difference. |
Siprj
changed the title
Fix the need for empty [settings] section in the `config.toml` to get default values for the whole section. This was caused by inconsistency in default instance and serde instances for the `SettingsModuleConfig` data structure. This PR helps to reduce the chance of it ever happening again.
|
Ok, I added the discussed refactoring. I think it is ready to be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the need for an empty [settings] section in the
config.tomlto get default values for the whole section.This was caused by inconsistency in default instance and serde instances for the
SettingsModuleConfigdata structure.Closes #291