Skip to content

Conversation

@iwkse
Copy link

@iwkse iwkse commented Aug 22, 2016

def get_page(self, n):
return FSRequest.request(self.next, {‘page’: n}, self.client, Pager)

didn't work for me, but I'd be glad to know if it's my mistake.

"""
return FSRequest.request(self.previous, {}, self.client, Pager)
def get_page(self, n):
url = self.next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail if self.next is None (which could happen if there are no other pages)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mon, 29 Aug 2016 08:07:56 -0700
Frederic Font [email protected] wrote:

@@ -281,6 +281,23 @@ def previous_page(self):
Get a Pager with the previous results page.
"""
return FSRequest.request(self.previous, {}, self.client, Pager)

  • def get_page(self, n):
  •    url = self.next
    

This will fail if self.next is None (which could happen if there are no other
pages)

True, but it's not going to fail because I do check the boundaries and this is
not called

Salvatore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants