Skip to content

Conversation

@Manangka
Copy link
Contributor

@Manangka Manangka commented Aug 4, 2025

This examples demonstrates the different advection schemes available in MODFLOW.
It includes the newly added UTVD scheme.

Three waves are advected through a square domain:

  • sin2-wave: This is a smooth wave which should demonstrate 2nd order convergence for the Central and UTVD scheme
  • block-wave: This should demonstrate that the TVD limiters fall back to a first order method in order to prevent oscilations
  • step-wave: See block wave

These 3 test cases are performed on 3 different kinds of grids:

  • structured
  • triangular
  • voronoi

@Manangka Manangka marked this pull request as draft August 4, 2025 08:24
@Manangka Manangka marked this pull request as ready for review August 9, 2025 09:56
@mjr-deltares
Copy link
Contributor

Hey @Manangka , this looks really nice! One quick thing: have you checked the layout of the figures in the resulting PDF? When I download the artifact, the figures in there appear to be running off the page...

Copy link

@aprovost-usgs aprovost-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the new chapter (#62) in pdf form and sent a markup with comments to @Manangka

@mjr-deltares
Copy link
Contributor

mjr-deltares commented Sep 2, 2025

Hi @Manangka (CC @wpbonelli @aprovost-usgs ) , we discussed with the team today that it would be advisable to delay this until after the upcoming maintenance release where we will likely cherry pick around utvd and other ongoing/recent developments. Could you please hold off merging for a bit?

@Manangka
Copy link
Contributor Author

Manangka commented Sep 3, 2025

Hi @Manangka (CC @wpbonelli) , we discussed with the team today that it would be advisable to delay this until after the upcoming maintenance release where we will mask utvd and other ongoing/recent developments. Could you please hold off merging for a bit?

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants