Fix no location result from getLocation with "Precise Location" off on iOS #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat gets returned when 'precise location' has been turned off to be ignored.
|
To view this pull requests documentation preview, visit the following URL: docs.page/lyokone/flutterlocation~984 Documentation is deployed and generated using docs.page. |
|
@Lyokone - Would it be possible to merge this? It seems to fix several issues we are facing using the getLocation() method. Thanks. |
|
@Lyokone any hopes on merging this? |
|
hello @Lyokone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "precise location" is turned off on iOS, calling
getLocationcaused the app to wait indefinitely for a location response.The root cause is that the guard condition in the code ignores the first two retrieved locations. However, with "precise location" turned off, only one location result seems to be obtained. This means the code never gets past the guard, resulting in no location being returned.
This fix bypasses the guard when "precise location" is off.
Fixes: #892, #815, #748