Add awareness of some Armv8.1-M branch instructions #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armv8.1-M adds some new direct branch instructions. This commit adds support for parsing WLS, WLSTP, LE, and LETP instructions. The branch future (BF) family of instructions is not handled by this commit.
|
I've tested this change locally using an ETM instruction trace stream that contains these instructions. However, I'm not sure what's the best way to add tests to the repository for |
|
@mikel-armbb I'd love to get your review and thoughts on testing |
|
HI, This seems a reasonable patch - however is it possible for you to provide a test in "snapshot" format that demonstrates the correct behaviour. See the "snapshots" directory for examples of other tests - the snapshot format is documented in the Docs area Thanks Mike |
|
Thanks, it'll take me some time to figure out how to generate non-proprietary test data in the right format, but I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Armv8.1-M adds some new direct branch instructions. This commit adds support for parsing WLS, WLSTP, LE, and LETP instructions.
The branch future (BF) family of instructions is not handled by this commit.