Skip to content

Conversation

MatrixFrog
Copy link

@MatrixFrog MatrixFrog commented Oct 7, 2021

Read props at render time, instead of in the constructor. That way if props change we're always reading the latest values.

I haven't tested this yet. I tried doing yarn install && yarn test and got some error while it was trying to compile node-sass or something.

@GitCop
Copy link

GitCop commented Oct 7, 2021

There were the following issues with your Pull Request

  • Commit: 5ba62cd
  • Commits must be in the following format: %{scope}: %{type} %{description}

Guidelines are available at https://github.com/LeoNero/react-img-zoom.
"%{type}" must be one of "add, remove, refactor, bump, move, release, update, fix"


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Oct 7, 2021

There were the following issues with your Pull Request

  • Commit: 9d2d627
  • Your subject line is longer than 50 characters

Guidelines are available at https://github.com/LeoNero/react-img-zoom.
"%{type}" must be one of "add, remove, refactor, bump, move, release, update, fix"


This message was auto-generated by https://gitcop.com

Read props at render time, instead of in the constructor. That way if
props change we're always reading the latest values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants