Fix GHCR image tags #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the solution that I was waiting for. Thanks, Hebert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I found a bug when try to install this package using the helm chart and I would like to suggest the fix for this.
The error is
ErrImagePulland this bug start when this repo migrate from dockerhub to ghcr. This happens because the helm chart try to download the imageghcr.io/labbs/github-actions-exporter:v1.9.0(here), but this image tag doesn't exists on ghcr.All image tags on ghcr was generated without the prefix
vand my suggestion is put this prefix to mantain the same pattern that was used in the dockerhub.So I did this fix using the docker metadata docs and below have the comparasion tags:
latest, sha-5e37462, 1, 1.9, 1.9.0latest, sha-5e37462, v1, v1.9, v1.9.0