allow Squeezeplay to display date in parentheses next to the album #1179
Conversation
| # ********************************************************************** | ||
| # *** This is a performance-critical method *** | ||
| # Take cake to understand the performance implications of any changes. | ||
| # Take care to understand the performance implications of any changes. |
There was a problem hiding this comment.
The truth lies in the cake, doesn't it? 😁
There was a problem hiding this comment.
Looking good for a first PR! Thanks!
Unfortunately I'm a big hesitant to merge at this point, as I could imagine this to cause quite a bit of opinionated discussions... "I want to be able to turn this off!". People don't like changes to what they became used to seeing.
So what I'd suggest is to wait for 9.0 to be released and put this in whatever comes next (9.1). And you could make it depend on the showYear pref: there's an option to "show year with albums" in the standard web UI. This mostly applies to album lists and such, but could probably satisfy some of the naysayers.
And please also test with online radio stations and such. Thanks!
This patch allows Squeezeplay to display the date in parentheses next to the album in Now Playing. This makes it behave similar to Material. No modifications to Squeezeplay are required.
This is my first ever LMS pull request, so I’m looking for feedback and guidance if I’m off the mark here.
test plan: