Skip to content

Conversation

svaningelgem
Copy link
Contributor

Closes #163

@Krakenied
Copy link
Collaborator

The feature itself is really useful; however, I'm not sure if it's the best implementation that could have been done. The first problem with it is that the Bukkit#getOfflinePlayers method is such an expensive one, as already mentioned in the documentation. The performance impact wouldn't be that problematical if we used the method asynchronously and then synchronously operated on the data.

Also, I'm not sure if we shouldn't add some additional confirmations to commands ran with the all argument. It's easy to mistype the argument especially when a player has nickname starting with all prefix, which may lead to widespread data loss or undesired modification.

@svaningelgem
Copy link
Contributor Author

I'm at a loss how to do that, but feel free to use the idea to build upon 😄

@LMBishop
Copy link
Owner

LMBishop commented Jan 9, 2024

I shall convert this to a draft to be picked up in the future then

@LMBishop LMBishop marked this pull request as draft January 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to fullreset for everybody
3 participants