Skip to content

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jul 9, 2025

Currently, trying to thicket.groupby("column").agg() on a single profile will error of the form

AttributeError: 'numpy.int64' object has no attribute 'to_dict'

since there is a pandas.squeeze function that returns a different type based on the shape of the dataframe. This change accounts for the case when df.shape = (1,1)

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 9, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title Fix agg on single profile single column Fix Groupby Aggregation on Single Column, Single Profile DataFrame Jul 9, 2025
@michaelmckinsey1 michaelmckinsey1 added status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jul 9, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (89ab916) to head (92e6606).

Files with missing lines Patch % Lines
thicket/groupby.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
+ Coverage    82.75%   82.85%   +0.10%     
===========================================
  Files           65       65              
  Lines         4482     4485       +3     
===========================================
+ Hits          3709     3716       +7     
+ Misses         773      769       -4     
Files with missing lines Coverage Δ
thicket/groupby.py 91.66% <60.00%> (-0.89%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants