Prevent negative scores #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
When n >= 4, it is possible to get a negative keyword score returned. This is occurs when there are two or more stopwords in a row. This causes
sum_h < -1and so the denominator remains negative when calculatingself.hfor the composed word.This PR remedies this by treating a chain of stopwords as a single entity for calculating h. When a stopword is located, we calculate
prob_t1as before. Now,prob_t2is calculated using the final stopword in the chain. The loop then skips to the word following the chain.As all existing tests use n <= 3, their result remains unchanged. An additional test for n=4 is added in English using a portion of text from https://en.wikipedia.org/wiki/Natural_language_processing.
Furthermore, the CONTRIBUTING.rst is updated to reflect the use of poetry as a package manager.