-
Notifications
You must be signed in to change notification settings - Fork 39
Using Custom Yaml Loader for topological map subscription #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arsh09
wants to merge
47
commits into
humble-dev
Choose a base branch
from
safe-yml-loader
base: humble-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new mission profile row operation
Row operation
Poop topo nodes
adding row operation action
pd regulator params
setting pd params for planner
publish node tag
…e accessing 'meta' or 'tag': list index out
…safe laoders using yaml
* Added toponap edit tool This Python script provides a graphical interface for editing a topological map stored in a YAML file. Using `tkinter` and `matplotlib`, users can interactively edit node attributes (position, orientation, properties), scale polygons, and globally update node names. The script allows for quaternion-to-yaw conversions and provides save and scale functionalities for adjusting polygon sizes. Node edges and positions are visually represented, and users can easily edit node details by clicking on them * Poop topo nodes (#187) * Add manual population node for topological navigation nodes [ROS2] * adding launch file * Update test_navigationcore.py - increase test timeout --------- Co-authored-by: Marc Hanheide <[email protected]> * added an initial schema (#196) * added an initial schema * changed additional properties * allow top-level optional elements like transformation * parameters shouldn't use ~ (#197) this fixes it. * Updating the topological map visualization when the map topic gets update. (#199) * using custom safe loader to load the topo map string. This avoids the float-type error in ROS2 for pose.x|y|z and orientaton.w|x|y|z. * updating the topological_map_visualisation on the topological_map_2 subscriber callback so rviz2 viz updates properly. --------- Co-authored-by: Marc Hanheide <[email protected]> Co-authored-by: Muhammad Arshad Khan <[email protected]>
…dgeActionManager and TopologicalNavServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…safe laoders using yaml
What type of PR is this? (check all applicable)
Description
This PR is an extension of #199 and use the consistent
yaml
package instead of a mix ofyaml
andjson
to load thetopolological_map_2
from topic subscription or local map file. It utilisesCustomYamlLoader
to make sure eachx
,y
,z
andw
fields are infloat
instead ofint
otherwisegeometry_msgs
complain about it.Ideally, these loaders can be used to verify the formatting of
nodes
andedges
or overalltopological_map
.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes.
[optional] Are there any post deployment tasks we need to perform?