add jabs-cli prune command; implement project metadata merging for jabs-init command #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergsalex
reviewed
Nov 10, 2025
…ng all pruned videos instead of after each video removed
bergsalex
approved these changes
Nov 10, 2025
ptuan5
reviewed
Nov 10, 2025
ptuan5
left a comment
ptuan5
left a comment
There was a problem hiding this comment.
I think it's good to merge. Made some minor suggestions for brevity, but does not functionality.
| List of pathlib.Path objects for all related files. | ||
| """ | ||
| paths: list[Path] = [] | ||
| base = Path(video_name).with_suffix("").name |
There was a problem hiding this comment.
is it any different than Path(video_name).stem?
| self._project_info.pop("metadata", None) | ||
| for video_entry in video_files.values(): | ||
| video_entry.pop("metadata", None) | ||
|
|
There was a problem hiding this comment.
If I'm not wrong, line 143-138 is redundant, because you reassign these values later on anyway?
| click.echo("Pruning cancelled.") | ||
| return | ||
|
|
||
| for video_paths in videos_to_prune: |
There was a problem hiding this comment.
I would change this to video_path or video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new command called "prune" to the
jabs-cliscript,provides a cli-based way for pruning unlabeled videos from a JABS project (functionality already exists in the GUI).
cli command is more complete in that it also removes derived files (GUI pruning tries to move videos, poses, and annotations to recycle bin, but does not remove cache files, features, predictions). GUI should be updated in a future PR to add missing functionality using new helper functions now available as part of this PR.
Also updates behavior of importing metadata with
jabs-init. Add option to merge or replace when importing new metadata file (previous behavior only allowed complete replacement, there was no way to merge)