Skip to content

Migrate structural #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jginternational
Copy link
Member

Another one I can not run @rubenzorrilla

structure_as_geometry.gid.zip

@jginternational
Copy link
Member Author

Depends on #985

@rubenzorrilla
Copy link
Member

structure_as_geometry.gid.zip

To make it work, I added:

  • properties 1 to the mdpa
  • assigning the properties to the entire model part so the conditions also have properties (hacky, as I conditions should have different properties than the elements)

@rubenzorrilla
Copy link
Member

structure_as_geometry.gid.zip

I'd do something like this

  • there are no properties in the mdpa
  • we assign the "fake" 0 properties to the conditions in the StructuralMaterials.json (we can hardcode this for the moment)

@rubenzorrilla
Copy link
Member

Indeed, al these issues come from the fact that our gid_output_process.py maps our properties to output layers. Rather than adding fake properties to the materials json, I think we'd better amend the output stuff.

@jginternational jginternational marked this pull request as ready for review July 19, 2024 16:01
@jginternational jginternational merged commit 8caca1b into write-geoms-migration Jul 26, 2024
@jginternational jginternational deleted the structural-migration-write-geoms branch July 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants