NameValueProperty
#1545
Open
NameValueProperty
#1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
reviewed
Nov 4, 2025
| // region Deprecated | ||
|
|
||
| /** A [DataSchema] interface / class can implement this if it represents a map-like data schema (so key: value). */ | ||
| @Deprecated(KEY_VALUE_PROPERTY, ReplaceWith("NameValueProperty<T>")) |
There was a problem hiding this comment.
Just curious, is it working as expected? Never tried replace with + generics
These changes should not cause any issues with the IDEA plugin. I checked locally how rendering of |
…aluePair inherit NameValueProperty, bringing them closer together
Jolanrensen
force-pushed
the
NameValueProperty
branch
from
f0523fc to
4369b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659 2nd attempt. (see first attempt here)
After discussing with @koperagen, this time I did it the other way around; keeping the names 'name' and 'value' instead of 'key' and 'value'.
Deprecated
KeyValuePropertyin favor ofNameValueProperty. MadeNameValuePairinheritNameValueProperty, bringing them closer together.@Allex-Nik same question as for the first attempt :)