proof of concept: use DraggableGridLayout for all dashboard rendering #2133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MA-3940
This PR is mostly a proof of concept for using GridStack for all render paths of dashboards. It has two changes that may generate some discussion:
However, this solves:
gridSize
andfitToContent
from the dashboard definitionGridLayout
Current layout path issue, top is editor view, bottom is viewer view
Note that the bottom view cuts off the last visualization and adds a scrollbar
If we use GridStack instead, we get this for the viewer (which is what is intended):
Dashboards with fit to content tiles are currently special cased
Note the extra space generated by our secondary render path (
GridLayout
) marked with a red arrow:Gridstack handles this case a slightly different way, also marked with a red arrow:
Dashboard responsiveness
Gridstack actually does a really good job of this, we just need to turn on the option.