Skip to content

feat: implement the Match mode for adoption for Konnect cloud gateway… #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2025
Merged

feat: implement the Match mode for adoption for Konnect cloud gateway… #2429

merged 6 commits into from
Oct 15, 2025

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Oct 11, 2025 •
edited
Loading

… entities

What this PR does / why we need it:

Which issue this PR fixes

Fixes #2116

Special notes for your reviewer:

Due to the numerous changes in this modification, for convenience in review, I have split it into two PRs. We can choose to directly review this PR or first review #2455 , and then I will rebase this PR after it is merged.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@tao12345666333 tao12345666333 self-assigned this Oct 11, 2025
randmonkey
randmonkey reviewed Oct 11, 2025
View reviewed changes
@tao12345666333 tao12345666333 mentioned this pull request Oct 11, 2025
Merged
1 task
@tao12345666333 tao12345666333 force-pushed the feat-match-mode-adoption branch 2 times, most recently from 3d38a5c to 547aa77 Compare October 13, 2025 13:42
@tao12345666333
Copy link
Member Author

https://github.com/Kong/kong-operator/actions/runs/18467784217/job/52619461965

go: toolchain upgrade needed to resolve sigs.k8s.io/controller-runtime/tools/setup-envtest
go: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.25.0 (running go 1.24.6; GOTOOLCHAIN=local)
ERROR ~/work/kong-operator/kong-operator/ingress-controller/bin/plugins/setup-envtest/bin/install failed
Error: 
   0: Failed to install asdf:[email protected]: 
         0: ~/work/kong-operator/kong-operator/ingress-controller/bin/plugins/setup-envtest/bin/install exited with non-zero status: exit code 1

      Location:
         src/plugins/script_manager.rs:184

      Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
      Run with RUST_BACKTRACE=full to include source snippets.

xref: #2149

@tao12345666333 tao12345666333 force-pushed the feat-match-mode-adoption branch 5 times, most recently from 0e61875 to 11182bf Compare October 14, 2025 15:05
@tao12345666333 tao12345666333 marked this pull request as ready for review October 14, 2025 15:58
@tao12345666333 tao12345666333 requested a review from a team as a code owner October 14, 2025 15:58
randmonkey
randmonkey reviewed Oct 15, 2025
View reviewed changes
@tao12345666333 tao12345666333 force-pushed the feat-match-mode-adoption branch 2 times, most recently from b909799 to d9800a4 Compare October 15, 2025 08:40
randmonkey
randmonkey reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, only some minor comments on simplifying comparison methods.

randmonkey
randmonkey reviewed Oct 15, 2025
View reviewed changes
@tao12345666333 tao12345666333 force-pushed the feat-match-mode-adoption branch from 72b3477 to dea2f64 Compare October 15, 2025 09:37
@tao12345666333 tao12345666333 force-pushed the feat-match-mode-adoption branch from dea2f64 to 05ac518 Compare October 15, 2025 09:38
@tao12345666333 tao12345666333 added this to the KO v2.1.x milestone Oct 15, 2025
@tao12345666333 tao12345666333 added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 3f0bc84 Oct 15, 2025
65 of 68 checks passed
@tao12345666333 tao12345666333 deleted the feat-match-mode-adoption branch October 15, 2025 11:02
@tao12345666333 tao12345666333 mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randmonkey randmonkey randmonkey approved these changes

Assignees

@tao12345666333 tao12345666333

Labels

None yet

Projects

None yet

Milestone

KO v2.1.x

Development

Successfully merging this pull request may close these issues.

Implement the "Match" mode adoption for Konnect cloud gateway entities

2 participants

@tao12345666333 @randmonkey