Skip to content

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Sep 5, 2025

closes INS-1450

POC:

  • run some codemods and bump to react 19
  • mismerge libraries don't support react 19.

What can we do to resolve this and unblock our upgrade path?

@CurryYangxx @cwangsmv @yaoweiprc

Update Sept25:

mismerge is unblocked

todo

  • fix lint and types
  • establish what should be done about useEffects and deps
  • test

Notes:

  • will use react compiler later in a seperate PR
  • lots of tests failure from timeouts and loose selectors, going to split out a bump to playwright and react-aria to hopefully help

@ZxBing0066
Copy link
Member

ZxBing0066 commented Sep 8, 2025

Cool! 🚀

image

But I don't think it's safe to remove the useCallback or useMemo before setting up the react-compiler(and it's still on rc, no stable version yet) and confirming it works for all of our scenarios, as it causes regressions.

And it seems all the icon files have removed the usage of SVGProps but not removed the imports, and their 'props' implicitly have an 'any' type. It seems they're not ready yet?

@CurryYangxx
Copy link
Member

Seems we need to find a replacement for mismerge.

@yaoweiprc
Copy link
Contributor

Sorry for the late reply.
The mismerge core defines a custom element 'mis-merge3' and doesn’t actually depend on any specific React version.
It was only the @mismerge/react package that deliberately restricted the React version.
I’ve removed the dependency on @mismerge/react and now only rely on @mismerge/core.
#9145

@jackkav
Copy link
Contributor Author

jackkav commented Sep 25, 2025

Awesome work @yaoweiprc I will take another look at this today

@ZxBing0066 I'll try to explore our options here and figure out a path forward.

@jackkav jackkav changed the title React-19 Upgrade to React 19 Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants