Add dynamic mock [INS-5485] #190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jackkav
reviewed
Jun 13, 2025
lib/routes/bins/update.js
Outdated
| ); | ||
| // TODO: add switch in client | ||
| // TODO: add it to create | ||
| mock._dynamicMockInBody = true; |
There was a problem hiding this comment.
nice job so far, how do you propose to determine this value in the client?
Why do we need to know this, is it an early optimisation? does the library waste resource if given a string without tags? If not it could be avoided, and we can just let the library optimise itself.
yaoweiprc
force-pushed
the
feat/dynamic-mock
branch
from
36d8ba5 to
6b9eabb
Compare
yaoweiprc
force-pushed
the
feat/dynamic-mock
branch
from
e320c6c to
2770a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.