feat: insight cog #423
Merged
feat: insight cog #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 87.35% 87.49% +0.14%
==========================================
Files 125 130 +5
Lines 9110 9214 +104
==========================================
+ Hits 7958 8062 +104
Misses 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JayDwee
requested changes
Oct 9, 2023
had missed out a space in a message to be sent
JayDwee
requested changes
Oct 10, 2023
koala/cogs/insights/core.py
Outdated
| partial_message += f", {guild}" | ||
| messages.append(partial_message) | ||
| else: | ||
| return [f"No servers found containing the string \"{filter_string}\"."] |
There was a problem hiding this comment.
This can just return empty list, and have cog.py deal with sending this message if result = []
koala/cogs/insights/cog.py
Outdated
| """ | ||
|
|
||
| for message in get_servers(self.bot, filter_string): | ||
| await ctx.send(message) |
There was a problem hiding this comment.
We should not use ctx.send this many times for one request as we could hit the ratelimit. We should instead group up to 2k characters into one message using \n then if more than 2k characters move to new message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #95
Checklist
CHANGELOG.mdunder the[Unreleased]heading?documentation.json?