-
Notifications
You must be signed in to change notification settings - Fork 47
[WIP] add a form upload extension #149
base: develop
Are you sure you want to change the base?
Conversation
Form/Extension/FormExtension.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmh couldn't you add a form error in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I think too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's still moving. a local commit is changing this. will be pushed soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty pretty good
|
Cool pull request and nice shot of you :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 should be on same line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't like it when it's on the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm crazy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then keep the new line (and your pills)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be $parent->getConfig()->getOption()
|
If anyone is up to finish this (if needed), go on :) |
|
What do you think about allowing overriding the upload path in the file field options? Use case is when having many |
|
@gquemener indeed! |
|
🌵 |
No description provided.