Added PDAL 2.9.2 as an option #772
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please |
daniel-riehm
requested changes
Sep 26, 2025
| if (GDAL_SELECT_VERSION VERSION_GREATER_EQUAL 3.5) | ||
| if (NOT LINUX) | ||
| if (NOT UNIX) | ||
| message(ERROR "Fletch currenly only supports building GDAL Version \"${GDAL_SELECT_VERSION}\" for Linux.") |
There was a problem hiding this comment.
Suggested change
| message(ERROR "Fletch currenly only supports building GDAL Version \"${GDAL_SELECT_VERSION}\" for Linux.") | |
| message(ERROR "Fletch currently only supports building GDAL Version \"${GDAL_SELECT_VERSION}\" for Unix.") |
| set(PDAL_version "1.7.2") | ||
| set(PDAL_url "https://data.kitware.com/api/v1/file/6622b24edf5a87675edbc0d0/download/pdal.${PDAL_version}.tar.gz") | ||
| set(PDAL_md5 "a89710005fd54e6d2436955e2e542838") | ||
| endif() |
There was a problem hiding this comment.
Add an else here (example: SQLite3 above)?
Pushed minimal cmake version to 3.6.0 to fix issues with building the python ci container for kwiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding version 2.9.2 as an option for PDAL. The old version of PDAL was not compatible with the new GDAL (3.11).