Skip to content

[fix] SwaggerUI 관련 설정 수정 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[fix] SwaggerUI 관련 설정 수정 #319

wants to merge 1 commit into from

Conversation

@linglong67
Copy link
Collaborator

💡 Motivation and Context

SwaggerUI 관련 설정 수정 → prod 환경에서 문서 노출 방지


🔨 Modified

build.gradle, cicd-prod.yml 수정

  • build.gradle 내 buildDir -> deprecated 되어 다른 방식으로 변경함
  • build.gradle 내 bootJar -> apiDocNeeded 설정값에 따라 다르게 동작하도록 변경
  • cicd-prod.yml -> gradle bootJar 시 apiDocNeeded 설정값 추가

🌟 More

  • ...

📋 커밋 전 체크리스트

  • 추가/변경에 대한 단위 테스트를 완료하였습니다.
  • 컨벤션에 맞게 작성하였습니다.

🤟🏻 PR로 완료된 이슈

closes #

@linglong67
fix: build.gradle, cicd-prod.yml 수정
0c91c53 
- build.gradle 내 buildDir -> Deprecated 되어 다른 방식으로 변경함
- build.gradle 내 bootJar -> apiDocNeeded 설정값에 따라 다르게 동작하도록 변경
- cicd-prod.yml -> gradle bootJar 시 apiDocNeeded 설정값 추가
@linglong67 linglong67 added 🖥️ BackEnd 서버 관련 💡 Feature 새로운 기능 추가, 혹은 구현 ⚙️ Settings 프로젝트 설정, 혹은 기타 환경설정 labels Mar 22, 2024
@linglong67 linglong67 self-assigned this Mar 22, 2024
chan99k
chan99k approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@chan99k chan99k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/cicd-prod.yml
run: |
chmod +x ./gradlew
./gradlew bootJar
./gradlew bootJar -PapiDocNeeded=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 어떤 역할을 하는 설정인가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

운영 환경에서는 API 문서를 생성되지 않게 하려고 파라미터 넘기는 거에요~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chan99k chan99k chan99k approved these changes

@HyunJunSon HyunJunSon Awaiting requested review from HyunJunSon HyunJunSon is a code owner

@gunsight1 gunsight1 Awaiting requested review from gunsight1 gunsight1 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@linglong67 linglong67

Labels

🖥️ BackEnd 서버 관련 💡 Feature 새로운 기능 추가, 혹은 구현 ⚙️ Settings 프로젝트 설정, 혹은 기타 환경설정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linglong67 @chan99k