-
-
Notifications
You must be signed in to change notification settings - Fork 175
Enable non-critical MCU support for CAN devices #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This fixed my issue perfectly. Had a Cartographer on CAN that would disconnect after a few hours of printing and kill the job. It's my second CAN device on the bus so can confirm it works with 2 devices. |
|
Hi, My goal was to see if Klipper could avoid crashing when I detach a tool from the system. Initially, it seemed to work. However, when I run simple HOME or MOVE commands without my SBB_2209 board connected, Klipper shuts down quite quickly with the following error: |
|
i tested this with one of isik's boards. i2c timeouts on the BME280 crash the whole system even though it's set as non-critical. |
That use case will likely require a lot more development and testing.. Unfortunately, this feature is not the primary goal. |
Thanks for the feedback. The whole i2c connection isnt ready for non-critical yet |
aeffab6 to
251cc25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, but can someone verify with this rebased to newest main?
This PR enables non-critical MCU support for CAN bus devices, allowing them to be disconnected and reconnected without causing errors or requiring a Klipper restart. Previously, this functionality was limited to USB devices, but with the changes from #391 that allowed querying of already-assigned devices, we can now extend this feature to CAN bus devices as well.
I tested:
I did not test: