Award DU upon engine ignition #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d or 1/40th of max DU, whichever is higher. Move DU award to separate OnIgnition() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully igniting an engine will now award 1/40th of TestFlight's configured maximum DU.
This DU will only be awarded upon the first ignition of the engine during a flight. Subsequent ignitions on the same flight award no extra DU. If a vessel is recovered and re-flown, the first ignition on that flight will once again award DU.
This corrects the situation in which engines with high rated burn times gain very little DU when used many times on successful missions in low burn time applications. This is especially punishing if the engine has a low initial ignition chance but a much improved ignition chance at high DU. With this PR you need not suffer an engine failure first to substantially improve reliability.