Use QString::as_slice for String conversions #1323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have a
qstring: QString
and callqstring.to_string()
, here is what happens:QByteArray
.qstring
's UTF-8 data.String
and copy the data into it.String
of its own.That's a lot of work and it's unnecessary. All we have to do is get the UTF-16 data of
qstring
, which is a constant-time operation, and write that into the formatter.String::from(&qstring)
is still a bit more efficient thanqstring.to_string()
with this approach, but the gap is much smaller than before. Arguably small enough that we could just recommendqstring.to_string()
for simplicity's sake. I think the only difference is thatString::from(&qstring)
reserves as much space as it needs up front.