Feat/blocklist #269
Open
Feat/blocklist #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all blocks are now block and delete - lift method to store
This was referenced Oct 17, 2025
IzioDev
requested changes
Oct 25, 2025
There was a problem hiding this comment.
inside flushWalletHistory, should we allow also delete blocking list?
if not, deleteTenant on the blockedAddress repository seems not useful
| <div> | ||
| <div className="text-xs font-medium tracking-wide text-[var(--text-secondary)] uppercase"> | ||
| Address | ||
| export const ContactInfoModal: FC<ContactInfoModalProps> = ({ |
There was a problem hiding this comment.
What do you think on placing the block button here instead?
Comment on lines
+531
to
+538
| // Skip processing historical data for blocked addresses | ||
| const blocklistStore = useBlocklistStore.getState(); | ||
| if (blocklistStore.blockedAddresses.has(senderAddress)) { | ||
| console.log( | ||
| `Skipping historical handshake processing for blocked address: ${senderAddress}` | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think we can filter out a bit earlier in the flow to avoid potentially expensive computation (decryption).
HistoricalSyncer could take blockedAddress repository as parameter and filter out ignored participants (as early as possible). Or, if you want messaging store to still keep this responsibility, one filter per direction (sent/received) in each loop (line 413 and line 462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what?
initial 'block a contact' feature
adds:
ability to block from broadcasts or directs contact info pane
ability to see blocked addresses and a broadcast vis option in settings
stores the blocked address in db (also has the capacity for a 'reason') - note: my initial version included a reason field and allowed users to block an address straight from the settings, but I removed this as it was a little complicated handling the visibility states etc. So atm, we have no UI to add a reason and no way to block a contact unless its on their contact card.
blocking will delete any in db contact or messages. BUT in bcasts you will either still see a "Blocked Contact" message or no message (depending on your settings)
also adds
kasia-generalas a default initial channel. users can block now so this seems reasonable?