Skip to content

Spelling #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Spelling #100

wants to merge 39 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Nov 28, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@8e98257#commitcomment-60980950

The action reports that the changes in this PR would make it happy: jsoref@89d24b1

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections were generally suggested by Google Sheets. But every choice is my fault.

Of the last couple of PRs I've made around GitHub this has by far the most things proportionally that I suspect will be rejected by a project.

If certain files/paths should be excluded, it's fairly trivial for me to drop items, just let me know.

Similarly, if a specific correction family is incorrect, I can trivially drop the commit, just let me know.

(I might be slow to respond until January, this was queued a while ago but I only got around to processing it tonight.)

path: /firewall-policys
path: /firewall-policies
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this, so I expect this isn't a correct change

path: /forwarding-classs
path: /forwarding-class
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

path: /network-policys
path: /network-policies
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

network_policys:
network_policies:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

path: /network-policys?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80
path: /network-policies?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -21,7 +21,7 @@ const (
defaultTimeout = 30 * time.Second
)

// Config represents parameters of Сollector in the config file
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C here is not Latin.

name: "Get multiple metadatas using UUID and FQName",
name: "Get multiple metadata using UUID and FQName",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data is plural, although this sounds wrong both ways.

Policys interface{} `json:"policys"`
Policies interface{} `json:"policies"`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that a thing like this is an api break and thus unacceptable.

func (r *NetworkResponse) setPolicys(vn *models.VirtualNetwork) {
func (r *NetworkResponse) setPolicies(vn *models.VirtualNetwork) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that this is a public api and thus unacceptable

func (port *Port) getAsssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string {
func (port *Port) getAssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant