Skip to content

Fix tests, Core.TypeofVararg for Julia 1.7 and AOT #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Jan 12, 2021

I extracted this commit from the "transpose_and_slice" branch to focus on fixing the tests and AOT now that several issues have been resolved.

@mkitti
Copy link
Member Author

mkitti commented Jan 12, 2021

Hi @stevengj and @tkf ,

This PR makes PyCall nightly (1.7) compatible and updates the AOT code now that several issues have been resolved.

I believe it will also run the AOT tests on code in a PR rather than just on master. There was a line that would dev PyCall, but this just ended up pulling down master.
https://github.com/JuliaPy/PyCall.jl/pull/877/files#diff-4b46bebfbbf4ad893abfcd8217a3e897e27cf16134a5970b31739320ef5c0894L50

I extracted this from #876 so we can see that the tests pass without the other changes and so that these changes can be merged as soon as possible.

@stevengj stevengj merged commit ead312f into JuliaPy:master Jan 15, 2021
@stevengj
Copy link
Member

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants