CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mfherbst
force-pushed
the
compathelper/new_version/2025-03-27-01-02-41-913-00289040745
branch
from
e965941 to
8b0bf48
Compare
|
This is awaiting the upcoming Optim release, as of JuliaNLSolvers/Optim.jl#1140 |
|
This is failing because of OptimizationBase not being compatible with the new FowardDiff (SciML/OptimizationBase.jl#140). It seems that we only depend on Optimization because of GeometryOptimization (used by some tests). Given the seemingly uncontrolled amount of transitive dependencies that Optimization pulls in, shouldn't we switch GeometryOptimization to Optim? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
ForwardDiffpackage from0.10to0.10, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.