Add support for local RNG seed in Haar measure matrix generation and reproducibility tests #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument) for generating Haar measure matrices, allowing reproducible results. - Updated test suite to include reproducibility checks for Haar measure matrices.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 39.80% 39.82% +0.02%
==========================================
Files 12 12
Lines 819 821 +2
==========================================
+ Hits 326 327 +1
- Misses 493 494 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you get the codecov up? |
|
Sure! I’ll work on adding some tests to increase coverage and push the changes soon. |
apkille
reviewed
Jun 4, 2025
| @@ -30,30 +31,38 @@ struct Ginibre <: ContinuousMatrixDistribution | |||
| end | |||
|
|
|||
| """ | |||
| rand(W::Ginibre) | |||
| rand(rng::AbstractRNG, W::Ginibre) | |||
There was a problem hiding this comment.
Suggested change
| rand(rng::AbstractRNG, W::Ginibre) | |
| rand([rng::AbstractRNG,] W::Ginibre) |
| @@ -1,6 +1,6 @@ | |||
| #TODO implement O(n^2) method | |||
| """ | |||
| rand(W::Haar, n::Int) | |||
| rand(rng::AbstractRNG, W::Haar, n::Int) | |||
There was a problem hiding this comment.
Suggested change
| rand(rng::AbstractRNG, W::Haar, n::Int) | |
| rand([rng::AbstractRNG,] W::Haar, n::Int) |
same here.
| end # testset | ||
|
|
||
|
|
There was a problem hiding this comment.
These extra lines below don't seem necessary.
| @@ -54,6 +54,10 @@ function rand(W::Haar, n::Int, doCorrection::Int=1) | |||
| end | |||
| end | |||
|
|
|||
| rand(W::Haar, n::Int, doCorrection::Int=1)= rand(GLOBAL_RNG,W,n,doCorrection) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
These extra lines don't seem necessary
| [Q0+im*Q1 Q2+im*Q3;-Q2+im*Q3 Q0-im*Q1] | ||
| else | ||
| error(string("beta = ", beta, " not implemented")) | ||
| end | ||
| end | ||
|
|
||
|
|
||
| rand(W::Ginibre)=rand(GLOBAL_RNG, W) | ||
|
|
There was a problem hiding this comment.
These extra lines don't seem necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of a local random number generator (via the
rngargument) for generating Haar measure matrices, allowing for reproducible results when a specific seed is provided.Additionally, a new test has been added to verify the reproducibility of Haar matrix generation when using local RNG seeds.