-
Notifications
You must be signed in to change notification settings - Fork 4
Fix Issue #27 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix Issue #27 #28
Conversation
|
I submitted this PR a little too early. All tests ran successfully on my machine where Int === Int64, but I see some have failed in CI on x86 machines, where Int === Int32, and the @test_broken tests are actually no longer broken. I also now see from the comments preceding the "high nu" test set that Issue #27 overlaps with Issue #10. I'll modify this PR to replace the @test_broken tests to @test after which I think everything should work ok. |
|
Edit: Changing this to a WIP (Work In Progress) PR since the problem still occurs for even higher |
|
Ok, I've implemented an asymptotic formula from DLMF that is appropriate for large nu and small n. Now the first ten zeros of any of the four treated functions are returned correctly for any positive nu value. All zeros are returned correctly for nu less than or equal to at least 150. This corrects the problem mentioned in this comment to Issue #10. Here is an example of finding the correct first 25 zeros for the derivative of a Bessel Y function of order 150:
And here is an example showing that the first 10 zeros are correctly found for a ridiculously large value of
|


Add methods to
bessel_zero_asymptoticandbessel_deriv_zero_asymptoticthat promotenufromIntegerto float. Fixes Issue #27