Skip to content

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Sep 7, 2025

It is not intended for a package to ever add methods to the functions > or >=. The behavior is unchanged because x > y falls back to y < x (similarly with >= and <=).

Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.68%. Comparing base (bdf1855) to head (840a83e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   50.56%   49.68%   -0.89%     
==========================================
  Files          63       63              
  Lines        3536     3496      -40     
==========================================
- Hits         1788     1737      -51     
- Misses       1748     1759      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

It is not intended for a package to ever add methods to the functions
`>` or `>=`.
@nsajko nsajko force-pushed the delete_redundant_methods branch from b7b55cd to 840a83e Compare September 9, 2025 16:47
@nsajko nsajko changed the title delete redundant methods of functions !=, >, >= delete redundant methods of functions >, >= Sep 9, 2025
@nsajko
Copy link
Contributor Author

nsajko commented Sep 9, 2025

Reverted some changes, so this PR now only concerns > and >=.

@nsajko
Copy link
Contributor Author

nsajko commented Sep 9, 2025

This PR greatly decreases the amount of sysimage invalidation on loading this package. The unique invalidation count upon using DoubleFloats goes from 2034 to 1111.

Instructions to reproduce this result:

  • Do @snoop_invalidations using DoubleFloats before loading any other package except for SnoopCompileCore. Not even the REPL or Pkg may be loaded, because they load StyledStrings, which does some piracy, causing invalidation, thus affecting the result. So run a script, instead of running Julia interactively.

  • Use nightly Julia v1.13, commit JuliaLang/julia@5c93bf2.

  • Run the code twice: first to get everything precompiled, then restart the script to measure invalidation. This eliminates any invalidations that may be caused by type instabilities in Julia's precompilation code.

Data on each invalidation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant