Skip to content

Conversation

@yha
Copy link
Contributor

@yha yha commented Nov 30, 2020

A redo of JunoLab/Juno.jl#605 for ProgressLogging

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #35 (2afd01c) into master (10208bc) will increase coverage by 2.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   69.04%   71.66%   +2.61%     
==========================================
  Files           1        1              
  Lines         168      180      +12     
==========================================
+ Hits          116      129      +13     
+ Misses         52       51       -1     
Impacted Files Coverage Δ
src/ProgressLogging.jl 71.66% <100.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10208bc...2afd01c. Read the comment docs.

Copy link
Member

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pfitzseb pfitzseb requested a review from tkf December 8, 2020 10:01
@yha
Copy link
Contributor Author

yha commented Jan 17, 2021

bump

@pfitzseb pfitzseb merged commit ac8ede1 into JuliaLogging:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants