Skip to content

Fix from Neuromap system #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix from Neuromap system #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ea2e5
Fix from Neuromap system
jusack Jul 31, 2025
2934289
Add normalization and randomized test for Kaczmarz
nHackel Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Kaczmarz.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ function init!(solver::Kaczmarz, state::KaczmarzState{T, vecT}, b::vecT; x0 = 0)
if λ_ != λ_prev
# A must be unchanged, since we do not store the original SM
_, solver.denom, solver.rowindex = initkaczmarz(solver.A, λ_)
solver.rowIndexCycle = collect(1:length(rowindex))
solver.rowIndexCycle = collect(1:length(solver.rowindex))
if solver.randomized
solver.probabilities = T.(rowProbabilities(solver.A, rowindex))
solver.probabilities = T.(rowProbabilities(solver.A, solver.rowindex))
end
end

Expand Down
9 changes: 9 additions & 0 deletions test/testKaczmarz.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,15 @@ Random.seed!(12345)
x_approx = Array(solve!(S, arrayType(b)))
@test norm(x - x_approx) / norm(x) ≈ 0 atol = 0.1
end

# Normalization
for strategy in [SystemMatrixBasedNormalization(), MeasurementBasedNormalization()]
l2 = L2Regularization(0.1)
S = createLinearSolver(solver, arrayType(A), iterations=200, randomized=true, reg = l2, normalizeReg = strategy)
x_approx = Array(solve!(S, arrayType(b)))
@test norm(x - x_approx) / norm(x) ≈ 0 atol = 0.1
end

end
end
end
Expand Down
Loading