-
Notifications
You must be signed in to change notification settings - Fork 3
Flavour Tagging features #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Flavour Tagging features. (src/, examples/flavour-tagging)
…struction still have EEjet
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
A few improvements to .gitignore Make dependency on JetReconstruction for v1.0 (currently in development) Change back to EEJet (no alias needed) Update calling signatures
|
Hello @HarryWang0619 - thanks a lot for this. I have flipped this back to the development version of N.B. This breaks the "tests" albeit that we don't actually have any tests! Although we have a bit to do, particularly documentation and tests, as |
|
Hi @HarryWang0619, I saw that you requested a review from me: I have taken a look at the code and have it running. I agree with @graeme-a-stewart that it's probably sensible just to merge this one in and then iterate from there on smaller things. Thanks again for all of your work in getting things to this point! |
Changed EEJet type alias to EEJet from JetReconstruction Using Pkg in the example to compile 1.0.0-DEV version of JetReconstruction
More sincos() and inline simd to optimize.
Flavour Tagging features. (src/, examples/flavour-tagging).
This is the continue of JuliaHEP/JetReconstruction.jl#164.
TODO: