Skip to content

Conversation

@HarryWang0619
Copy link
Contributor

@HarryWang0619 HarryWang0619 commented Jul 27, 2025

Flavour Tagging features. (src/, examples/flavour-tagging).

This is the continue of JuliaHEP/JetReconstruction.jl#164.

TODO:

  • Tests
  • Tests GitHub workflow
  • Documentations (README.md, docs, etc.)

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

HarryWang0619 and others added 3 commits July 29, 2025 13:14
A few improvements to .gitignore
Make dependency on JetReconstruction for v1.0 (currently in development)
Change back to EEJet (no alias needed)
Update calling signatures
@graeme-a-stewart
Copy link
Member

graeme-a-stewart commented Aug 4, 2025

Hello @HarryWang0619 - thanks a lot for this. I have flipped this back to the development version of JetReconstruction (do Pkg.develop("JetReconstruction")) so that we don't get out of sync with the upcoming release.

N.B. This breaks the "tests" albeit that we don't actually have any tests!

Although we have a bit to do, particularly documentation and tests, as simple-flavour-tagging.jl is working, I propose to accept this PR and then continue with other PRs for the missing pieces.

@HarryWang0619 HarryWang0619 marked this pull request as ready for review August 4, 2025 18:08
@mattleblanc
Copy link

Hi @HarryWang0619, I saw that you requested a review from me: I have taken a look at the code and have it running. I agree with @graeme-a-stewart that it's probably sensible just to merge this one in and then iterate from there on smaller things.

Thanks again for all of your work in getting things to this point!

Changed EEJet type alias to EEJet from JetReconstruction
Using Pkg in the example to compile 1.0.0-DEV version of JetReconstruction
More sincos() and inline simd to optimize.
@mattleblanc mattleblanc merged commit 7630556 into JuliaHEP:main Aug 25, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants