Skip to content

Conversation

@michel2323
Copy link
Member

@michel2323 michel2323 commented Oct 31, 2025

Enable SPV_EXT_shader_atomic_float_add
Fixes #508

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler/compilation.jl b/src/compiler/compilation.jl
index 33d7764..01d1815 100644
--- a/src/compiler/compilation.jl
+++ b/src/compiler/compilation.jl
@@ -70,7 +70,7 @@ end
     # TODO: emit printf format strings in constant memory
     extensions = String[
         "SPV_EXT_relaxed_printf_string_address_space",
-        "SPV_EXT_shader_atomic_float_add"
+        "SPV_EXT_shader_atomic_float_add",
     ]
 
     # create GPUCompiler objects

@michel2323
Copy link
Member Author

Needs tests.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.10%. Comparing base (0c9c8b7) to head (fa63ecb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files          47       47           
  Lines        3001     3001           
=======================================
  Hits         2374     2374           
  Misses        627      627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with floating-point atomics

3 participants