Skip to content

Fix docs for reinterpret #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2019
Merged

Fix docs for reinterpret #619

merged 2 commits into from
Jun 21, 2019

Conversation

c42f
Copy link
Member

@c42f c42f commented Jun 21, 2019 •
edited
Loading

Fix #501

This is #502, but with the tweaks I suggested over there to avoid the average user accidentally invoking undefined behavior.

CC @chethega

Closes #502

chethega and others added 2 commits June 21, 2019 16:11
@chethega @c42f
docfix reinterpret
3d9351c
@c42f
Simplify svectors() doc example + remove unsafe variants
04922cd 
While these unsafe / illegal variants are interesting, it seems better
not to recommend code which may lead to UB in the documentation ;-)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.714% when pulling 04922cd on cjf/reinterpret-docfix into 83e134a on master.

@c42f c42f merged commit 1d881f3 into master Jun 21, 2019
@c42f c42f deleted the cjf/reinterpret-docfix branch June 21, 2019 11:25
@fredrikekre fredrikekre mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reinterpret of Arrays of static arrays failed
3 participants
@c42f @coveralls @chethega