Fix inference on axes for broadcasting #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #540 ? |
|
See also JuliaLang/julia#30074. |
timholy
commented
Nov 18, 2018
| @@ -58,3 +58,6 @@ end | |||
| Base.@pure function Base.checkindex(::Type{Bool}, ::SOneTo{n1}, ::SOneTo{n2}) where {n1, n2} | |||
| return n1::Int >= n2::Int | |||
| end | |||
|
|
|||
| Base.promote_rule(a::Type{Base.OneTo{T}}, ::Type{SOneTo{n}}) where {T,n} = | |||
| Base.OneTo{promote_type(T, Int)} | |||
There was a problem hiding this comment.
Hmm, this is not strictly necessary for the fix (it's just the first thing I tried). I could get rid of this if you have reservations about it. (One also has to be rid of the tests this adds to core.jl.)
andyferris
approved these changes
Nov 18, 2018
| @@ -58,3 +58,6 @@ end | |||
| Base.@pure function Base.checkindex(::Type{Bool}, ::SOneTo{n1}, ::SOneTo{n2}) where {n1, n2} | |||
| return n1::Int >= n2::Int | |||
| end | |||
|
|
|||
| Base.promote_rule(a::Type{Base.OneTo{T}}, ::Type{SOneTo{n}}) where {T,n} = | |||
| Base.OneTo{promote_type(T, Int)} | |||
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 66.12% 66.18% +0.05%
==========================================
Files 38 38
Lines 2893 2898 +5
==========================================
+ Hits 1913 1918 +5
Misses 980 980
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546