Skip to content

move the dataids method to the main file #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

nsajko
Copy link
Collaborator

@nsajko nsajko commented Jan 10, 2025

I think this may be tidier. The FixedSizeBitArray method would presumably go right next to this one.

I think this may be tidier. The `FixedSizeBitArray` method would
presumably go right next to this one.
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (66bdda0) to head (0fb27f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files           2        3    +1     
  Lines         227      227           
=======================================
  Hits          224      224           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsajko nsajko requested a review from giordano January 10, 2025 14:15
Copy link
Collaborator

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's also in #75, but probably good to have it in a separate PR.

@nsajko nsajko merged commit 10434f3 into JuliaArrays:main Jan 10, 2025
9 checks passed
@nsajko nsajko deleted the dataids branch January 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants