Skip to content

Conversation

@alexander-potemkin
Copy link

as mentioned at #2577

@alexander-potemkin alexander-potemkin requested a review from a team as a code owner August 13, 2025 17:28
@google-cla
Copy link

google-cla bot commented Aug 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexander-potemkin
Copy link
Author

CLA signed

Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

I have a couple of suggestions for this change. The Linux commands you've provided, while helpful, might not work for every user since different Linux distributions can have different ways of handling these configurations. To avoid potential issues, I recommend we remove the specific commands (especially the one related to sysctl.d).

Additionally, our long-term goal is to fully support both IPv4 and IPv6. Since disabling IPv6 is a temporary workaround, I think it's better to add this as a TODO item in the documentation (see my suggestion). This will signal that we're aware of the issue and plan to address it in the future, once we have the bandwidth.

Finally, I'd suggest putting the text in the Outline Client desktop README. This keeps the main document clean and ensures that users can find information directly relevant to their platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants