Skip to content

Conversation

@serge-p7v
Copy link
Contributor

Motivation and Context

There were two bug reports related to incompatibility of kotlinx-coroutines version: #273 and #678 The common cause is the method "Dispatchers.Default.limitedParallelism(5)" with different number of parameters in 1.8 (runtime) and 1.10 versions. The solution is to remove "Dispatchers.Default.limitedParallelism(5)" from AIAgentPipeline. This way we can improve the compatibility with kotlinx-coroutines 1.8 in runtime.
This PR is replacing that one #878

Breaking Changes

none, prepareFeatures method will use an existing CoroutineDispatcher instead of its own.


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Qodana for JVM

17374 new problems were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 16213
Check Kotlin and Java source code coverage 🔶 Warning 1148
Missing KDoc for public API declaration 🔶 Warning 11
If-Null return/break/... foldable to '?:' ◽️ Notice 2
@@ Code coverage @@
+ 71% total lines covered
15393 lines analyzed, 10936 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @serge-p7v 👍🏻

@kpavlov kpavlov requested a review from Ololoshechkin October 14, 2025 19:12
Copy link
Collaborator

@Ololoshechkin Ololoshechkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc @sdubov

@serge-p7v serge-p7v force-pushed the remove-featurePrepareDispatcher branch from 7b1070b to 6c2559c Compare October 27, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants