feat: Support Compose Resources in Native macOS Executables #5431
+263
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for Compose Resources in native macOS executables. - Added a new integration test `macosExecutableResources` to verify resource copying for macOS executables. - Updated `IosResources.kt` to handle resource copying for `Executable` binaries on macOS. - Resources are now copied into the `.app/Contents/Resources` directory for packaged macOS applications. - The `copyExecutableComposeResourcesFor[Target]` task is now configured for macOS executables. - Packaging tasks for macOS now depend on the corresponding resource copying task.
terrakok
requested changes
Sep 16, 2025
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/IosResources.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/IosResources.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/IosResources.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt
Outdated
Show resolved
Hide resolved
This commit introduces a new test project `misc/macosNativeResources` to verify the functionality of Compose resources in macOS native applications. The test project includes: - A simple Composable `App` that displays an image resource. - Vector drawable resources for the app icon and an image. - Gradle configuration for building a macOS native application (`.dmg`). - A `main.kt` for the macOS target. - `gradle.properties` to enable experimental macOS features. - `settings.gradle.kts` for project setup. The existing `ResourcesTest.kt` is updated to use this new test project for `macosExecutableResources` test, replacing the previous in-memory modification of the `misc/appleResources` project. This change allows for a more isolated and maintainable test for macOS native resources.
|
I revisited the codebase and decided the feature should be done in configureNativeApplication function. Could you refactor it? |
Ok |
Should i keep the |
|
Better to revert all changes. Because the file is related to ios specifics (yes, it helps with macos unit tests, as I see, but by chance 😄). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Compose Resources in native macOS executables.
macosExecutableResourcesto verify resource copying for macOS executables.IosResources.ktto handle resource copying forExecutablebinaries on macOS..app/Contents/Resourcesdirectory for packaged macOS applications.copyExecutableComposeResourcesFor[Target]task is now configured for macOS executables.Testing
Executing tasks: [:compose:test-Gradle(9.0.0)-Agp(8.9.0), --tests, org.jetbrains.compose.test.tests.integration.ResourcesTest.macosExectuableResources]
Executing tasks: [:compose:test-Gradle(9.0.0)-Agp(8.9.0), --tests, org.jetbrains.compose.test.tests.integration.ResourcesTest.macosTestResources]
Release Notes
Fixes - macOS Native